Remove pandas and datasets from core dependencies #8274
Merged
+1,973
−1,546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -66,6 +68,9 @@ dev = [ | |||
| ] | |||
| test_extras = [ | |||
| "mcp; python_version >= '3.10'", | |||
| "datasets>=2.14.6", | |||
There was a problem hiding this comment.
open for discussion - do you think it's better to have these go to dev or test_extras? My first impression is they belong to dev better, but not very sure
There was a problem hiding this comment.
I think test_extras should be a combination of all extra dependencies that are installed when running pytest. To my understanding, dev usually only contains packages that help development such as linter, test libraries. So we could include them in dev, but including them in test_extras is a must
TomeHirata
changed the title
TomeHirata
force-pushed
the
refactor/lite/dependencies
branch
from
96d1500 to
d887229
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since DSPy 3.0, DSPy does not include dependencies for optimizers such as
pandas, ordatasetsas its core dependencies. This is for making DSPy production-ready, allowing users to use DSPy programs without installing large dependencies during inference time. This PR reduces the file volume size of DSPy dependencies from 284 MB to 115MB.